Adjust permissions guide layout for small screens #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebromero
reviewed
Sep 9, 2020
Contributor
sebromero
left a comment
sebromero
left a comment
There was a problem hiding this comment.
Can we shrink the space between the title and the text in this case so that the text doesn't stick so close to the button?
Contributor
Author
|
Honestly I wouldn't spend too much time on such a small edge case. I can try, but instead I would rewrite the entire view controller when really needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation and Context
This PR fixes #14.
Description
I've adjusted some auto layout constraints in order to better fit in small screens. However I cannot guarantee that this will work for every language, as some labels might be too long to fit with this rigid design.
In the future I'd also suggest to remove the permissions request at the first launch, as it doesn't fit well with the iOS HIG. Instead we should ask for permissions on demand, when the user might need them.
Attached you can see screenshots of the fixed layout.