fix 6 year old bug in ipaddress.h #28
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I wonder if this would be better fixed by making the declaration in the .h file |
Member
|
Fixed by arduino/ArduinoCore-API@3dbd7d7 (as soon as AVR core will be based on chainsaw the patch will be applied here as well) |
Contributor
|
Closing this issue since initial port of Arduino API has been done and this issue is fixed with arduino/ArduinoCore-API@3dbd7d7 as noted by @facchinm . |
darkk
added a commit
to darkk/ArduinoCore-avr
that referenced
this pull request
Oct 29, 2025
NTPClient-based project shrunk per `size firmware.elf` - .text 30100 -> 29838: -262 bytes, -0.8% of Uno Flash - .bss 602 -> 542: -60 bytes, -2.9% of Uno SRAM That addresses arduino#28, arduino#461, arduino#463 and arduino/Arduino#1007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug causes multiple sram usage. Now only one instance should be in sram.
fix arduino/Arduino#1007