Declaring abs define in Arduino.h breaks compatibility with TensorFlow Lite

[janjongboom]

Why is abs defined in the Arduino.h for this core?

ArduinoCore-mbed/cores/arduino/Arduino.h

Line 70 in 682a054

#ifdef abs

This conflicts with std::abs usage f.e. in TensorFlow Lite. I think this has happened before in other cores, as there's a provision in TF already for this:

https://github.com/tensorflow/tensorflow/blob/845adc40a653b311f4df2c273b22de7e175a93a1/tensorflow/lite/type_to_tflitetype.h#L18

But it still required us to patch this undef in at a later point as well when porting EI to Portenta.

[facchinm]

Removing abs override works for me, but I'm wondering which version of TF you are compiling... 2.1.0-alpha works just fine on the Portenta using this core

Edit: I didn't open the link 🙂

[hpssjellis]

Any update on this. I got the TensorflowLite Hello_World code to run on the PortentaH7 by changing in the file arduino_output_handler.cpp LED_BUILTIN to pin 5, since LED_BUILTIN is 3V3 connected and does not do PWM.