all: Remove superfluous prefix from boards config

[sebromero]

This PR removes the superfluous prefix from the boards configuration which results in pre-compiler defines that have a duplicate ARDUINO_ prefix. To verify, enable verbose output in the IDE and you will see all the generated defines.

[per1234]

My concern with this change is that, in addition to the -DARDUINO_{build.board} that produces the superfluous prefix on the macro definitions, the compilation patterns also contain -D{build.board}. It is nice to use a prefix on global macro definitions to create a "namespace".

A generic macro name like GIGA seems prone to name collisions.

[pillo79]

A generic macro name like GIGA seems prone to name collisions.

Indeed that was the reasoning behind the choice: better to have an extra ARDUINO_ARDUINO_GIGA than a very generic version. Everyone should use ARDUINO_GIGA anyway.

[pennam]

A generic macro name like GIGA seems prone to name collisions.

Indeed that was the reasoning behind the choice: better to have an extra ARDUINO_ARDUINO_GIGA than a very generic version. Everyone should use ARDUINO_GIGA anyway.

why not also remove -D{build.board} to get rid of GIGA and keep only ARDUINO_GIGA. ARDUINO_ARDUINO_GIGA looks also wrong in my opinion.

[sebromero]

Totally agree with @pennam . If we don't want the board-only macro, let's remove it from the build process. @pillo79 You suggested to use the board name only without the prefix, that's why I made this PR 🙂

[pillo79]

A generic macro name like GIGA seems prone to name collisions.

Indeed that was the reasoning behind the choice: better to have an extra ARDUINO_ARDUINO_GIGA than a very generic version. Everyone should use ARDUINO_GIGA anyway.

why not also remove -D{build.board} to get rid of GIGA and keep only ARDUINO_GIGA. ARDUINO_ARDUINO_GIGA looks also wrong in my opinion.

EPIC FACEPALM!
I was absolutely sure it was done by the CLI somehow. Turns out there is no real reason but "always been this way". +1 from @facchinm as well on removing the prefixes and the -D{build.board}, so @sebromero please remove that from the platform.txt as well.