FIXME: disable additional_event_mask in NetworkInterface::begin() #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change addresses an issue where combining additional_event_mask with NET_EVENT_IPV4_ADDR_ADD in the net_mgmt_event_wait_on_iface function caused unexpected behavior due to Zephyr's internal event handling. By isolating the wait to only NET_EVENT_IPV4_ADDR_ADD, we ensure that the function behaves as intended. A more robust solution involving semaphores and multiple event registrations will be implemented in the future. Signed-off-by: Luca Burelli <l.burelli@arduino.cc>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses an issue where combining
additional_event_maskwithNET_EVENT_IPV4_ADDR_ADDin thenet_mgmt_event_wait_on_ifacefunction caused unexpected behavior due to Zephyr's internal event handling.By isolating the wait to only
NET_EVENT_IPV4_ADDR_ADD, we ensure that the function behaves as intended (and for all purposes, as it was before). A more robust solution involving semaphores and multiple event registrations will be implemented in the future.