Skip to content

Conversation

@Matteo-it
Copy link
Contributor

@Matteo-it Matteo-it commented Nov 24, 2025

Fan vibration monitoring Update UI

@Matteo-it Matteo-it force-pushed the Matteo-it/fan-vibration-monitoring branch from d62f63e to 6f7f0e9 Compare November 24, 2025 15:24
@Matteo-it Matteo-it marked this pull request as ready for review November 25, 2025 11:02
Copy link
Contributor

@mcmchris mcmchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Matteo-it I tested the code (I know this is work in progress) but I noticed that the chart was not being cleared and was showing an overlapped messy line chart. With this addition, this is fixed 🙏

@Matteo-it
Copy link
Contributor Author

@mcmchris thanks! I've commited your suggestion, i'm testing it again

@Matteo-it Matteo-it requested a review from mcmchris November 26, 2025 11:14
Copy link
Contributor

@mcmchris mcmchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Image

@mcmchris
Copy link
Contributor

@Matteo-it I have the README ready on a Fork (since I can't create branches from this repo), when this is merged to release-1.0, let me know so I can add my PR. Thanks

@Matteo-it Matteo-it force-pushed the Matteo-it/fan-vibration-monitoring branch from 8e85d45 to f65ba76 Compare November 26, 2025 14:44
Copy link
Contributor

@stefanotorneo stefanotorneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanotorneo stefanotorneo merged commit 973408e into release-1.0 Nov 28, 2025
2 checks passed
@stefanotorneo stefanotorneo deleted the Matteo-it/fan-vibration-monitoring branch November 28, 2025 09:51
mirkokurt added a commit that referenced this pull request Dec 2, 2025
* Replace SineGenerator with WaveGenerator Brick in Theremin (#8)

* Mascot Jump Game Example Addition (#7)

* Add Bedtime story teller example (#15)

* Mascot Jump Game Update UI (#17)

* Add Object Hunting example documentation (#18)

* Update Theremin Simulator example documentation (#16)

* Add led-matrix-painter (#5)

* Docs: update bedtime story teller (#20)

* Fan vibration monitoring UI (#19)

* Vibration Anomaly Detection Example Documentation (#22)

* Led matrix UI improvement (#24)

* Docs led matrix painter (#26)

---------

Co-authored-by: Dario Sammaruga <48221340+BeanRepo@users.noreply.github.com>
Co-authored-by: Dario Sammaruga <d.sammaruga@ext.arduino.cc>
Co-authored-by: TaddyHC <94547080+TaddyHC@users.noreply.github.com>
Co-authored-by: Stefano Torneo <s.torneo@arduino.cc>
Co-authored-by: Matteo Marsala <matteo.marsala92@gmail.com>
Co-authored-by: Ernesto Voltaggio <92443068+91volt@users.noreply.github.com>
Co-authored-by: Christopher Méndez <49886387+mcmchris@users.noreply.github.com>
Co-authored-by: Stefano Torneo <121802192+stefanotorneo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants