Skip to content

Conversation

@lucarin91
Copy link
Contributor

@lucarin91 lucarin91 commented Oct 22, 2025

Motivation

The dpkg step in system update was meant only to fix the database corruption issue; if it fails, we could still attempt to update the packages.

Change description

Additional Notes

  • Fix also an issue that makes the upgrade operation exit without an error.

Reviewer checklist

  • PR addresses a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.

@lucarin91 lucarin91 requested review from Xayton, dido18 and mirkoCrobu and removed request for dido18 October 22, 2025 13:13
@lucarin91 lucarin91 marked this pull request as ready for review October 22, 2025 15:41
Copy link
Contributor

@Xayton Xayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are OK.
I quickly tested it and the basic update continue working.

@lucarin91 lucarin91 force-pushed the make-system-update-more-reliable branch from 1b013e4 to 87babba Compare October 23, 2025 08:08
@lucarin91 lucarin91 merged commit 0509013 into main Oct 23, 2025
5 checks passed
@lucarin91 lucarin91 deleted the make-system-update-more-reliable branch October 23, 2025 08:11
lucarin91 added a commit that referenced this pull request Oct 28, 2025
* fix(update): skip the dpkg step in case of error

* fix some iterator issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants