-
Notifications
You must be signed in to change notification settings - Fork 7
Get on board image version #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mirkoCrobu
wants to merge
10
commits into
main
Choose a base branch
from
issue_41_flasher_api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+178
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucarin91
requested changes
Dec 15, 2025
lucarin91
reviewed
Dec 15, 2025
lucarin91
requested changes
Dec 15, 2025
lucarin91
reviewed
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #41
Get the version of the image on the board to know if it supports user preservation when it is not in EDL mode. The equivalent of adb shell 'cat /etc/buildinfo' could be sufficient, but we want to return only the BUILD_ID.
If /etc/buildinfo does not exist, assume it is an R0 image and return it as the default value.
At this level, there is no way to check for EDL mode.
The current behavior is "if the board is detected. It is not in EDL mode."
In any case, this check will be done by the caller.
Change GetOsImageVersion()
Add test if possible
log - INFO
manual test, add the call in main() log - ERROR
Change description
Additional Notes
Reviewer checklist
main.