Skip to content

test(internal/orchestrator/modelsindex): add unit test for the model list index #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 31, 2025
Merged

test(internal/orchestrator/modelsindex): add unit test for the model list index #22

merged 7 commits into from
Oct 31, 2025

Conversation

@dido18
Copy link
Contributor

@dido18 dido18 commented Oct 24, 2025 •
edited
Loading

Motivation

Added unit test for the model-list.yaml file.

Change description

  • Add the missing ModelLabels to the go model

Additional Notes

Reviewer checklist

  • PR addresses a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.

@dido18
Copy link
Contributor Author

dido18 commented Oct 24, 2025

check coverage:

cd /home/dido/code/arduino/arduino-app-cli/internal/orchestrator/modelsindex && go test -cover -v -coverprofile=coverage.out  && go tool cover -html=coverage.out

@dido18 dido18 marked this pull request as ready for review October 24, 2025 14:04
@dido18 dido18 changed the title test(models-index): ad unit test for the model list index test(models-index): add unit test for the model list index Oct 24, 2025
@dido18 dido18 changed the title test(models-index): add unit test for the model list index test(internal/orchestrator/modelsindex): add unit test for the model list index Oct 24, 2025
@per1234 per1234 added the enhancement New feature or request label Oct 24, 2025
@dido18 dido18 requested a review from mirkoCrobu October 27, 2025 10:37
mirkoCrobu
mirkoCrobu reviewed Oct 28, 2025
View reviewed changes
mirkoCrobu
mirkoCrobu reviewed Oct 28, 2025
View reviewed changes
@dido18 dido18 merged commit da80048 into main Oct 31, 2025
5 checks passed
@dido18 dido18 deleted the test-models-index branch October 31, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mirkoCrobu mirkoCrobu mirkoCrobu approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dido18 @mirkoCrobu @per1234