-
Notifications
You must be signed in to change notification settings - Fork 1
[CLI] Add a "restart" app command #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I think we could also implement the endpoint. I could also find this useful for the FE, maybe in another PR |
|
I created the issue: https://github.com/bcmi-labs/orchestrator/issues/814 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You miss the check that the app running is the one you are trying to restart
90b0173 to
2fa49cc
Compare
The CLI provides a command to start and stop an app/example. Often it's useful to have a restart command, that will stop and start again the same app. This is needed only for the CLI interface. The command already exists. But error management should be improved: restarting an app X when app Y is running does not show a clear error if the app running is not the one being restarted: error if no app is running: just start the app
Motivation
The CLI provides a command to start and stop an app/example. Often it's useful to have a restart command, that will stop and start again the same app. This is needed only for the CLI interface.
The command already exists. But error management should be improved:
Change description
Additional Notes
Tested on board, arduino-app-cli v.365
Reviewer checklist
main.