Skip to content

Conversation

@mirkoCrobu
Copy link
Contributor

@mirkoCrobu mirkoCrobu commented Oct 30, 2025

Motivation

The CLI provides a command to start and stop an app/example. Often it's useful to have a restart command, that will stop and start again the same app. This is needed only for the CLI interface.

The command already exists. But error management should be improved:

  • restarting an app X when app Y is running does not show a clear error
  • if the app running is not the one being restarted: error
  • if no app is running: just start the app

Change description

Additional Notes

Tested on board, arduino-app-cli v.365

Reviewer checklist

  • PR addresses a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.

@mirkoCrobu mirkoCrobu requested a review from a team October 30, 2025 15:27
@mirkoCrobu mirkoCrobu self-assigned this Oct 30, 2025
@mirkoCrobu mirkoCrobu added the enhancement New feature or request label Oct 30, 2025
@lucarin91
Copy link
Contributor

This is needed only for the CLI interface.

I think we could also implement the endpoint. I could also find this useful for the FE, maybe in another PR

@mirkoCrobu mirkoCrobu changed the title add restart cli command [CLI] Add a "restart" app command Oct 30, 2025
@mirkoCrobu
Copy link
Contributor Author

I created the issue: https://github.com/bcmi-labs/orchestrator/issues/814

Copy link
Contributor

@lucarin91 lucarin91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You miss the check that the app running is the one you are trying to restart

@mirkoCrobu mirkoCrobu force-pushed the issue_552_restart_cli_command branch from 90b0173 to 2fa49cc Compare November 3, 2025 16:01
@mirkoCrobu mirkoCrobu merged commit 4170e9d into main Nov 3, 2025
6 checks passed
@mirkoCrobu mirkoCrobu deleted the issue_552_restart_cli_command branch November 3, 2025 17:19
mirkoCrobu added a commit that referenced this pull request Nov 4, 2025
The CLI provides a command to start and stop an app/example. Often it's useful to have a restart command, that will stop and start again the same app. This is needed only for the CLI interface.

The command already exists. But error management should be improved:

restarting an app X when app Y is running does not show a clear error
if the app running is not the one being restarted: error
if no app is running: just start the app
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants