Skip to content

Conversation

@cmaglie
Copy link
Member

@cmaglie cmaglie commented Oct 30, 2025

Motivation

Fix Websocket origin check.
In particular, Wails Apps on Windows uses the origin http://wails.localhost that was previously rejected, making the serial monitor unusable.

Change description

I've rewritten the origin check properly.

Additional Notes

Reviewer checklist

  • PR addresses a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.

@cmaglie cmaglie changed the title Fix websocket origin check fix: websocket origin check (fixes serial monitor on Windows) Oct 30, 2025
@cmaglie cmaglie self-assigned this Oct 30, 2025
@cmaglie cmaglie requested a review from a team October 30, 2025 15:58
@cmaglie cmaglie requested a review from lucarin91 October 30, 2025 16:08
@per1234 per1234 added the bug Something isn't working label Oct 30, 2025
@cmaglie cmaglie merged commit df2d206 into main Oct 31, 2025
6 checks passed
@cmaglie cmaglie deleted the fix_origin_check branch October 31, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants