Skip to content

feat(board): return adb stdout/err in case of error #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2025
Merged

feat(board): return adb stdout/err in case of error #40

merged 2 commits into from
Nov 3, 2025

Conversation

@lucarin91
Copy link
Contributor

@lucarin91 lucarin91 commented Oct 31, 2025 •
edited
Loading

Motivation

We should always include the command stdout/stderr in case the process fails.

Change description

Additional Notes

Reviewer checklist

  • PR addresses a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.

@lucarin91 lucarin91 requested a review from a team October 31, 2025 11:20
@per1234 per1234 added the bug Something isn't working label Oct 31, 2025
@lucarin91 lucarin91 merged commit a2f7219 into main Nov 3, 2025
6 checks passed
@lucarin91 lucarin91 deleted the board-adb-add-error-out branch November 3, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Xayton Xayton Xayton approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lucarin91 @Xayton @per1234