Skip to content

fix(pkg/board): handler error in GetCmd creation #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2025
Merged

fix(pkg/board): handler error in GetCmd creation #79

merged 2 commits into from
Nov 18, 2025

Conversation

@lucarin91
Copy link
Contributor

@lucarin91 lucarin91 commented Nov 17, 2025 •
edited
Loading

Motivation

We should return an error if we aren't able to create a process in adb.GetCmd.

Change description

Additional Notes

Reviewer checklist

  • PR addresses a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.

@per1234 per1234 added the bug Something isn't working label Nov 17, 2025
@lucarin91 lucarin91 requested review from a team and martacarbone November 17, 2025 17:25
@lucarin91 lucarin91 marked this pull request as ready for review November 17, 2025 17:28
@lucarin91 lucarin91 merged commit 4d105dd into arduino:main Nov 18, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martacarbone martacarbone martacarbone approved these changes

@dido18 dido18 dido18 approved these changes

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lucarin91 @martacarbone @dido18 @per1234