Skip to content

fix(pkg/board): handler error in GetCmd creation #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2025
Merged

fix(pkg/board): handler error in GetCmd creation #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd2524c
fix(pkg/board): handler error in GetCmd creation
lucarin91 Nov 17, 2025
19e53d2
fixup! fix(pkg/board): handler error in GetCmd creation
lucarin91 Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions pkg/board/remote/adb/adb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@ func (a *ADBConnection) Remove(path string) error {

type ADBCommand struct {
cmd *paths.Process
err error
}

func (a *ADBConnection) GetCmd(cmd string, args ...string) remote.Cmder {
Expand All @@ -243,19 +244,31 @@ func (a *ADBConnection) GetCmd(cmd string, args ...string) remote.Cmder {
cmds = append(cmds, args...)
}

command, _ := paths.NewProcess(nil, cmds...)
return &ADBCommand{cmd: command}
command, err := paths.NewProcess(nil, cmds...)
return &ADBCommand{cmd: command, err: err}
}

func (a *ADBCommand) Run(ctx context.Context) error {
if a.err != nil {
return fmt.Errorf("failed to create command: %w", a.err)
}

return a.cmd.RunWithinContext(ctx)
}

func (a *ADBCommand) Output(ctx context.Context) ([]byte, error) {
if a.err != nil {
return nil, fmt.Errorf("failed to create command: %w", a.err)
}

return a.cmd.RunAndCaptureCombinedOutput(ctx)
}

func (a *ADBCommand) Interactive() (io.WriteCloser, io.Reader, io.Reader, remote.Closer, error) {
if a.err != nil {
return nil, nil, nil, nil, fmt.Errorf("failed to create command: %w", a.err)
}

stdin, err := a.cmd.StdinPipe()
if err != nil {
return nil, nil, nil, nil, fmt.Errorf("failed to get stdin pipe: %w", err)
Expand Down