Add require_model to the brick list #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giulio93
force-pushed
the
add_required_model_field
branch
from
68e4ca0 to
a091a26
Compare
lucarin91
reviewed
Nov 20, 2025
Contributor
lucarin91
left a comment
lucarin91
left a comment
There was a problem hiding this comment.
You should regenerate the openapi
giulio93
changed the title
mirkoCrobu
requested changes
Nov 20, 2025
Contributor
mirkoCrobu
left a comment
mirkoCrobu
left a comment
There was a problem hiding this comment.
You should regenerate the openapi
And after regenerating it, you can integrate "internal/e2e/daemon/brick_test.go"(test: func TestBricksList(t *testing.T) ), checking the new field.
dido18
reviewed
Nov 21, 2025
giulio93
force-pushed
the
add_required_model_field
branch
2 times, most recently
from
50e7c7f to
fceed39
Compare
Contributor
Author
|
mirkoCrobu
reviewed
Nov 24, 2025
dido18
reviewed
Nov 24, 2025
lucarin91
requested changes
Nov 24, 2025
giulio93
force-pushed
the
add_required_model_field
branch
2 times, most recently
from
5b2b73d to
3acd7d6
Compare
This was referenced Nov 24, 2025
Contributor
Author
|
close:#90 |
Contributor
Author
|
close:#88 |
dido18
reviewed
Nov 24, 2025
lucarin91
requested changes
Nov 24, 2025
giulio93
force-pushed
the
add_required_model_field
branch
3 times, most recently
from
7e1ab7f to
f629dbf
Compare
dido18
requested changes
Nov 24, 2025
dido18
reviewed
Nov 24, 2025
dido18
reviewed
Nov 25, 2025
giulio93
force-pushed
the
add_required_model_field
branch
from
0504fb2 to
0a49ae4
Compare
giulio93
force-pushed
the
add_required_model_field
branch
from
0a49ae4 to
c44f649
Compare
dido18
reviewed
Nov 26, 2025
giulio93
force-pushed
the
add_required_model_field
branch
from
7b7291c to
20bc5e0
Compare
dido18
approved these changes
Nov 26, 2025
Co-authored-by: Davide <davideneri18@gmail.com>
Co-authored-by: Davide <davideneri18@gmail.com>
Co-authored-by: Davide <davideneri18@gmail.com>
giulio93
force-pushed
the
add_required_model_field
branch
from
5a01856 to
5eb18f8
Compare
mirkoCrobu
approved these changes
Nov 26, 2025
lucarin91
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR add the required_model field on brick:
Additional Notes
require_modelboolen in brick list/details #88require_modelfor the app bricks (installed into an app) #90