install.sh to work with wget #2619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
… Now install.sh works with wget as download tool.
Member
|
@MilosSubotic thanks for your submission, I tested it and it works. Before I can merge it I need to ask you to sign the CLA. |
cmaglie
approved these changes
Jun 12, 2024
cmaglie
added
topic: infrastructure
per1234
added
status: blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I run install.sh on freshly installed Ubuntu so did not have curl installed as most people do, so it fallback to wget, but there was a bug in getFile(). Here is correction.