Skip to content

fix: check free disk space and allow to specify a different download/extraction directory #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

fix: check free disk space and allow to specify a different download/extraction directory #23

wants to merge 10 commits into from

Conversation

@MatteoPologruto
Copy link
Contributor

@MatteoPologruto MatteoPologruto commented Nov 3, 2025 •
edited
Loading

Motivation

The default download/extraction directory might be on a disk with insufficient space.

Change description

Two changes have been introduced:

  • allow the user to set a different temporary directory in which the Debian image is downloaded and/or extracted, using the --temp-dir flag;
  • check that the temporary directory is in a disk with enough free space before starting a download/extraction.

Additional Notes

Reviewer checklist

  • PR addresses a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.

@MatteoPologruto MatteoPologruto self-assigned this Nov 3, 2025
@MatteoPologruto MatteoPologruto added the bug Something isn't working label Nov 3, 2025
@MatteoPologruto MatteoPologruto linked an issue Nov 3, 2025 that may be closed by this pull request
Check available disk space before downloading/extracting images #17
Open
per1234
per1234 previously requested changes Nov 3, 2025
View reviewed changes
@MatteoPologruto MatteoPologruto marked this pull request as ready for review November 3, 2025 16:22
@MatteoPologruto MatteoPologruto requested a review from a team November 3, 2025 16:22
@MatteoPologruto @per1234
Update updater/download_image.go
c6f32e4 
Co-authored-by: Per Tillisch <accounts@perglass.com>
@per1234 per1234 dismissed their stale review November 3, 2025 16:26

Requested changes have been made. Thanks!

lucarin91
lucarin91 reviewed Nov 5, 2025
View reviewed changes
MatteoPologruto and others added 4 commits November 6, 2025 14:30
@MatteoPologruto @lucarin91
Update updater/download_image.go
a3cb5fe 
Co-authored-by: Luca Rinaldi <lucarin@protonmail.com>
@MatteoPologruto @lucarin91
Update updater/download_image.go
760eebc 
Co-authored-by: Luca Rinaldi <lucarin@protonmail.com>
@MatteoPologruto
Apply review suggestion
a320fba
@MatteoPologruto
Change helper function name
9ddd61a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucarin91 lucarin91 lucarin91 left review comments

@per1234 per1234 per1234 left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@MatteoPologruto MatteoPologruto

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Check available disk space before downloading/extracting images

3 participants

@MatteoPologruto @lucarin91 @per1234