feat: refactor import paths and add feedback and i18n packages #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Build tested locally with |
Contributor
MatteoPologruto
left a comment
MatteoPologruto
left a comment
There was a problem hiding this comment.
Just some nitpicks
Co-authored-by: MatteoPologruto <109663225+MatteoPologruto@users.noreply.github.com>
…-flasher-cli into remove-orch-dependencies
MatteoPologruto
approved these changes
Oct 15, 2025
lucarin91
pushed a commit
that referenced
this pull request
Oct 28, 2025
* feat: refactor import paths and add feedback and i18n packages * feat: update copyright and licensing information in source files Co-authored-by: MatteoPologruto <109663225+MatteoPologruto@users.noreply.github.com> --------- Co-authored-by: MatteoPologruto <109663225+MatteoPologruto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove external dependencies by copying/pasting the
i18nandfeedbackpackages here.Other
github.com/arduino/arduino-flasher-cliaddlicense -c "ARDUINO SA (http://www.arduino.cc/)" -f ./license_header.tpl $(find . -name "*.go" -type f -print0 | xargs -0)Other notes
i18ncan be removed. Translation can be added when needed