Use Go tool system to manage "go-bindata" tool dependency #981
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "go-bindata" tool is used to embed the JSON schemas used by Arduino Lint's rules as Go code, allowing the tool installation to consist of a single executable file. Previously, the tool was installed via a `go install` command in the task. This approach is problematic for several reasons: - It installs the tool globally (in GOBIN), and thus pollutes the contributor's global environment - The tool must be updated manually Since go-bindata is a Go module-based project, it can be installed and managed by using the Go modules system, which has explicit support for tool dependencies as of the Go 1.24 release. This will allow keeping the dependency updated via the Dependabot service, just as is done with the Go module dependencies of the codebase, and other tool dependencies.
per1234
added
type: enhancement
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #981 +/- ##
=======================================
Coverage 83.33% 83.33%
=======================================
Files 1 1
Lines 180 180
=======================================
Hits 150 150
Misses 19 19
Partials 11 11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Nov 3, 2025
I discovered that I was mistaken about this effect. Although Dependabot does provide update PRs when tool dependencies are managed via the alternative provisional " |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The go-bindata tool is used to embed the JSON schemas used by Arduino Lint's rules as Go code, allowing the tool installation to consist of a single executable file.
Previously, the tool was installed via a
go installcommand in the task. This approach is problematic for several reasons:GOBIN), and thus pollutes the contributor's global environmentSince go-bindata is a Go module-based tool, it can be installed and managed by using the Go modules system, which has explicit support for tool dependencies as of the Go 1.24 release.
This will allow keeping the dependency updated via the Dependabot service, just as is done with the Go module dependencies of the codebase, and other tool dependencies.