Improve version number regex in installation script #988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…syntax
A script is provided to facilitate installation of Arduino Lint.
The grep utility is used for several purposes in the script.
grep supports multiple flavors of regular expression syntax:
* "basic" (BRE)
* "extended" (ERE)
* "perl" (PCRE)
The default "BRE" syntax is inconsistent with the syntax used in all other common regular expression applications:
> In basic regular expressions the meta-characters ?, +, {, |, (, and ) lose their special meaning; instead use the
> backslashed versions \?, \+, \{, \|, \(, and \).
The "PCRE" syntax that would otherwise be preferred is not available when using grep on BSD/macOS machines.
So grep should be configured to use the "ERE" in scripts that are intended to be cross-platform (as is the case with
this script).
The installation script scrapes the GitHub releases page for the version number of the latest release. A regular expression is used to extract the version number from the title. Previously, the regular expression would return a corrupted version number if the name of the repository owner or repository contained numbers. For example, if used in a repository owned by GitHub user `per1234`, where the latest release version was 1.2.3, it would return the following version number: ``` 1.2.3 1234 ```
per1234
added
topic: infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installation script scrapes the GitHub releases page for the version number of the latest release. A regular expression is used to extract the version number from the title.
Previously, the regular expression would return a corrupted version number if the name of the repository owner or repository contained numbers. For example, if used in a repository owned by GitHub user
per1234, where the latest release version was 1.2.3, it would return the following version number: