Skip to content

[PC-1432] - Portenta C33 User Manual Update #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 26, 2023
Merged

[PC-1432] - Portenta C33 User Manual Update #1434

merged 7 commits into from
Oct 26, 2023

Conversation

@canchebagur
Copy link
Contributor

@canchebagur canchebagur commented Oct 24, 2023 •
edited by jcarolinares
Loading

What This PR Changes

  • This PR updates the user manual of the Portenta C33 with information related to the I2C ports.

Contribution Guidelines

@gatsby-cloud
Copy link

gatsby-cloud bot commented Oct 24, 2023 •
edited
Loading

✅ docs-content deploy preview ready

@canchebagur canchebagur self-assigned this Oct 24, 2023
@canchebagur canchebagur added documentation Improvements or additions to documentation fix/update A small fix or update arduino Bugs and fixes added by the Arduino Team pro labels Oct 24, 2023
martab1994
martab1994 reviewed Oct 25, 2023
View reviewed changes
Copy link
Contributor

@martab1994 martab1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As said, I don't know if we need the note too, up to you :) otherwise, everything looks great to me!

jcarolinares
jcarolinares requested changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change that I will commit myself

The rest is perfect

thank you @canchebagur

jcarolinares
jcarolinares requested changes Oct 26, 2023
View reviewed changes
jcarolinares
jcarolinares requested changes Oct 26, 2023
View reviewed changes
jcarolinares
jcarolinares approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcarolinares jcarolinares merged commit cd55cda into main Oct 26, 2023
@jcarolinares jcarolinares deleted the canchebagur/c33-user-manual-update branch October 26, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martab1994 martab1994 martab1994 left review comments

@jcarolinares jcarolinares jcarolinares approved these changes

Assignees

@canchebagur canchebagur

Labels

arduino Bugs and fixes added by the Arduino Team documentation Improvements or additions to documentation fix/update A small fix or update pro

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@canchebagur @jcarolinares @martab1994