Skip to content

Conversation

@canchebagur
Copy link
Contributor

@canchebagur canchebagur commented Apr 7, 2023

What This PR Changes

  • This PR adds the NDP firmware and Alexa demo model update process.

Contribution Guidelines

@gatsby-cloud
Copy link

gatsby-cloud bot commented Apr 7, 2023

✅ docs-content deploy preview ready

@canchebagur canchebagur self-assigned this Apr 10, 2023
Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done, just a couple of request.

@canchebagur please proceed when you have time, thank you!

canchebagur and others added 2 commits April 18, 2023 11:28
…-started-ml/content.md

Co-authored-by: Julián Caro Linares <j.carolinares@arduino.cc>
@canchebagur
Copy link
Contributor Author

@jcarolinares, your review comments have been addressed. I thinks it is ready to be merged 😃

@canchebagur canchebagur added fix/update A small fix or update arduino Bugs and fixes added by the Arduino Team pro labels Apr 18, 2023
@canchebagur
Copy link
Contributor Author

@martab1994 I changed the tutorial title as you suggested in the Nicla Voice user manual PR. Let me know if it is ok.

Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@canchebagur
Copy link
Contributor Author

canchebagur commented Apr 21, 2023

@martab1994 @jcarolinares

"Getting Started with Machine Learning Audio Models on the Nicla Voice" is too long (more than 60 characters stated by the Linter tool). My suggestion is the following:

image

Audio Analysis with Machine Learning and the Nicla Voice, I added the "getting started" in the tutorial description. Hence, the users know the tutorial is intended to be a getting-started guide. Let me know if it is ok, changes are already made.

@jcarolinares
Copy link
Contributor

It

@martab1994 @jcarolinares

"Getting Started with Machine Learning Audio Models on the Nicla Voice" is too long (more than 60 characters stated by the Linter tool). My suggestion is the following:

image

Audio Analysis with Machine Learning and the Nicla Voice, I added the "getting started" in the tutorial description. Hence, the users know the tutorial is intended to be a getting-started guide. Let me know if it is ok, changes are already made.

It's a great proposal and we always have time to change the title to new ones if we need too

To not block/delay decisions, please fo with it!

Copy link
Contributor

@jcarolinares jcarolinares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Title proposal already on the file

Approved

Merging

@jcarolinares jcarolinares merged commit 25e8673 into main Apr 21, 2023
@jcarolinares jcarolinares deleted the canchebagur/nicla-voice-alexa-fix branch April 21, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arduino Bugs and fixes added by the Arduino Team fix/update A small fix or update pro

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants