Skip to content

fix (macos): handle error when removing old app during update process #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix (macos): handle error when removing old app during update process #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion updater/apply_darwin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,11 @@ func apply(targetPath string, current releaser.Version, client *releaser.Client,

// Remove old app
slog.Info("Removing old app", "to", oldAppPath)
_ = oldAppPath.RemoveAll()
err = oldAppPath.RemoveAll()
// TODO: added only to debug why it is not able to remove the old app, remove later
if err != nil {
return "", fmt.Errorf("could not remove old app: %w", err)
}

slog.Info("Returning updated app", "path", currentAppPath)

Expand Down