Skip to content

Conversation

@janikheiler
Copy link
Contributor

i am about to change my username to janikheiler. therefore i would like to change the url :)

i am about to change my username to janikheiler. therefore i would like to change the url :)
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Hi @whoelsethanjesus.
Your pull request has been detected as something other than a Library Manager submission.
A maintainer will need to review it before it can be merged.

If you intended to submit a library, please check the instructions and update your pull request if necessary:
https://github.com/arduino/library-registry/blob/main/README.md#instructions

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

A problem was found with your submission https://github.com/janikheiler/Mintrix

ERROR: Unable to load submission URL. Is the repository public?

@github-actions github-actions bot added the topic: modification Change existing list entry label Nov 8, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023

Thanks for your interest in contributing to the Arduino Library Manager index @whoelsethanjesus
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@github-actions github-actions bot requested a review from per1234 November 8, 2023 20:13
@per1234 per1234 self-assigned this Nov 9, 2023
@per1234 per1234 added topic: URL change Change library repository URL and removed topic: modification Change existing list entry labels Nov 9, 2023
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @whoelsethanjesus. Thanks for your care about keeping the registry data up to date. I see that the change has not yet occurred, which is the cause of the problem reported by the bot that the new URL https://github.com/janikheiler/Mintrix does not load.

We should wait on making this change until the URL is valid. So you should proceed with changing your GitHub username. Once you have done that, please comment here on the pull request thread to let us know we can proceed.

If you use GitHub's username change feature (instead of creating a new account under the new name), then GitHub automatically sets up redirects from the old URLs of your repositories to the new URLs so you won't break anything by changing your username. However, we still encourage library maintainers to submit URL update requests here even when a redirect is in place because we would prefer to avoid a reliance on those redirects, which aren't guaranteed to continue working forever.

@per1234 per1234 added the status: blocked Progress on this prevented by an external cause label Nov 9, 2023
@janikheiler
Copy link
Contributor Author

Hi @per1234 ,
thanks for the comment. I thought I'd wait until you changed it so you have proof that really I wanted to change it and not some other account. Anyways. I changed my name now. :)

@per1234 per1234 mentioned this pull request Nov 9, 2023
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @janikheiler. I am confirming your request.

Unlike submissions, this type of request is still handled manually. The Library Manager index maintainer occasionally comes through to clear all the outstanding requests. They will merge this pull request when it is done. You will get a notification from GitHub at that time.

After that, you can monitor the indexing of the library via its dedicated logs web page.
Information about that here:
https://github.com/arduino/library-registry/blob/main/FAQ.md#can-i-check-on-library-releases-being-added-to-library-manager

I thought I'd wait until you changed it so you have proof that really I wanted to change it and not some other account.

That is very much appreciated. We do verify the legitimacy of requests for changes to existing library registrations. In this particular case, GitHub's redirect of the previous URL to the new URL is sufficient verification, but in other cases it can be challenging to verify requests so you definitely took the appropriate approach to this.

@per1234 per1234 added status: pending backend Depends on backend maintenance operations and removed status: blocked Progress on this prevented by an external cause labels Nov 9, 2023
@per1234 per1234 removed their assignment Nov 9, 2023
@MatteoPologruto MatteoPologruto self-assigned this Nov 14, 2023
Copy link
Contributor

@MatteoPologruto MatteoPologruto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done:

2023/11/14 16:50:57 Loaded 6367 libraries from DB
Changing URL of library Mintrix from https://github.com/whoelsethanjesus/Mintrix.git to https://github.com/janikheiler/Mintrix.git
Success!

@MatteoPologruto MatteoPologruto merged commit ae8f56d into arduino:main Nov 14, 2023
@MatteoPologruto MatteoPologruto added the conclusion: resolved Issue was resolved label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conclusion: resolved Issue was resolved status: pending backend Depends on backend maintenance operations topic: URL change Change library repository URL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants