fix(virtual-device): fix mqtt on ios version > 13 untrust certificate #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rformato
reviewed
Jan 9, 2023
rformato
suggested changes
Jan 9, 2023
rformato
left a comment
rformato
left a comment
There was a problem hiding this comment.
I've just found a typo in the comments. Other than this, it LGTM
alessioemireni
force-pushed
the
fix/ios-ssl
branch
from
f4ca464 to
48dcbfe
Compare
rformato
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the self-signed certificate released from backend with iOS devices with OS version > 13.
Per documentation now the maximum validity for a certificate is 397 days:
https://support.apple.com/en-us/HT211025