chore(phone-as-device): app-481 get private key from Keychain #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessioemireni
assigned
balsick and
alessioemireni and unassigned
alessioemireni and
balsick
rformato
reviewed
Jul 12, 2023
|
|
||
| let status = SecItemCopyMatching(query as CFDictionary, &result) | ||
|
|
||
| if status == errSecSuccess { |
There was a problem hiding this comment.
If we have an error here, do we manage to reject the parent promise?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to modify the actual flow that sets the client cert in the Keystore/Keychain.
Previously we pass a PEM containing the string representation of the private key, now we pass the key that gets the private key from the Keystore/Keychain (it's not possible to encode the private key --> https://stackoverflow.com/a/35822695/6324764).
If you want to test please use this PR --> https://github.com/bcmi-labs/iot-cloud-remote-ios/pull/348