Provide control over the source of the timestamp #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Tom suggested renaming the record so that it matches ADVimba's, I've amended the commit |
coretl
reviewed
Nov 15, 2023
This allows selecting between getting the timestamp from the camera or from the system running the IOC. The system timestamp is obtained from the aravis buffer which was saved on the reception of the first packet of the image, this is more precise than timestamping after receiving the full frame.
Member
Author
|
Given that my use-case turned out to work fine using the epics timestamp, I'm closing the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows selecting between getting the timestamp from the camera or from the system running the IOC.
The system timestamp is obtained from the aravis buffer which was saved on the reception of the first packet of the image, this is more precise than timestamping after receiving the full frame.
The reason why this change is needed is because we have certain cameras in which PTP doesn't work and using the system
timestamp in the aravis buffer would be good enough for our application.