Remove comparing NexusDataType codes with NDDataTypeCodes #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 20, 2024 15:09
NDAttribute was being compared with NX attributes.
Not only did the code do nothing after the the comparison (it simply
fell to default case), this also risks breaking the compilation after new
additions to NDAttrDataType_t.
For example: NX_CHAR = 4, which is the same of NDAttrInt32.
Another example: after trying to add types to NDAttrDataType_t I got:
../ADApp/pluginSrc/NDFileNexus.cpp: In member function 'void NDFileNexus::constTextToDataType(char*, int, void*)':
../ADApp/pluginSrc/NDFileNexus.cpp:726:5: error: duplicate case value
case NDAttrUndefined:
^~~~
../ADApp/pluginSrc/NDFileNexus.cpp:681:5: note: previously used here
case NX_UINT8:
^~~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HI! We stumbled upon this when trying to add vector options to NDAttrDataType_t.
Regardless if vector options are actually going to be added, when NDAttrUndefined was moved to the 21th position of NDAttrDataType_t it collided with NX_UINT8 in NDFileNexus.cpp:663:
Since that case condition actually does nothing but fall to the default case, we thought it would be healthy to remove it.