Add support for lz4hdf5 codec

[MarkRivers]

This adds support for the lz4hdf5 codec to NDPluginCodec and NDFileHDF5. The codec itself is in ADSupport. There are also changes to ADEiger to use this new codec for Stream2 LZ4 compression, and to ADViewers to display arrays with this codec in ImageJ.

[ericonr]

Isn't this missing the changes to

ADCore/ADApp/pluginSrc/NDFileHDF5Dataset.cpp

Line 299 in 6c53844

else if (pArray->codec.name == codecName[NDCODEC_LZ4]) {

to properly pass the data through to the HDF5 file without inserting any metadata?

[ericonr]

Should we add our own compress_bound_lz4hdf5 function in ADSupport? The checking performed by compress_lz4hdf5 is reasonably complex and I don't think it should be repeated across the code base.

As is, I believe this size would cause compress_lz4hdf5 below to error out.

[ericonr]

I think this change in order would be nice to at least document in release notes, since I believe it could break someone's autosave.

[MarkRivers]

I have added this to RELEASE.md

[MarkRivers]

Isn't this missing the changes to
ADCore/ADApp/pluginSrc/NDFileHDF5Dataset.cpp to properly pass the data through to the HDF5 file without inserting any metadata?

No. The codecName for lz4hdf5 is NDCODEC_LZ4HDF5, not NDCODEC_LZ4, and there is no special treatment required for that codec in NDFileHDF5Dataset.cpp. I have tested this. Here is the output of h5dump --header -p on a file saving NDArrays compressed with lz4hdf5 with a block size of 65000. This was generated with ADSimDetector and NDPluginCodec.

            DATATYPE  H5T_STD_U8LE
            DATASPACE  SIMPLE { ( 100, 1024, 1024 ) / ( 100, 1024, 1024 ) }
            STORAGE_LAYOUT {
               CHUNKED ( 1, 1024, 1024 )
               SIZE 1545960 (67.827:1 COMPRESSION)
            }
            FILTERS {
               USER_DEFINED_FILTER {
                  FILTER_ID 32004
                  COMMENT HDF5 lz4 filter; see http://www.hdfgroup.org/services/contributions.html
                  PARAMS { 0 0 }
               }
            }