Fix naming of header and variable in NDPluginAttribute tests#588
Merged
jwlodek merged 2 commits intoMay 22, 2026
Conversation
Member
|
ericonr
reviewed
May 21, 2026
Member
There was a problem hiding this comment.
Can you wrap the text of the second commit? Something like
Expose NDPluginCodec functions with NDPLUGIN_API
This way, the compress/decompress functions can be accessed with
-fvisibility=hidden.
This fixes linking test_NDPluginAttribute with function compressZlib.
This way, the compress/decompress functions can be accessed with -fvisibility=hidden. This fixes linking test_NDPluginAttribute with function compressZlib.
efe4896 to
255665f
Compare
Member
Author
|
Done |
ericonr
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Naming was changed in previous PR, and the PR with these tests was merged before the changed names were applied