Skip to content

Fix naming of header and variable in NDPluginAttribute tests#588

Merged
jwlodek merged 2 commits into
areaDetector:masterfrom
jwlodek:fix-ndplugin-attribute-test
May 22, 2026
Merged

Fix naming of header and variable in NDPluginAttribute tests#588
jwlodek merged 2 commits into
areaDetector:masterfrom
jwlodek:fix-ndplugin-attribute-test

Conversation

@jwlodek
Copy link
Copy Markdown
Member

@jwlodek jwlodek commented May 21, 2026

Naming was changed in previous PR, and the PR with these tests was merged before the changed names were applied

@ericonr
Copy link
Copy Markdown
Member

ericonr commented May 21, 2026

  /home/runner/work/ADCore/ADCore/ADApp/pluginTests/O.linux-x86_64/../test_NDPluginAttribute.cpp:71:(.text+0xa37): undefined reference to `compressZlib(NDArray*, int, NDCodecStatus_t*, char*)'
  /usr/bin/ld: /home/runner/work/ADCore/ADCore/ADApp/pluginTests/O.linux-x86_64/../test_NDPluginAttribute.cpp:71:(.text+0x2717): undefined reference to `compressZlib(NDArray*, int, NDCodecStatus_t*, char*)'
  collect2: error: ld returned 1 exit status

@jwlodek jwlodek requested a review from ericonr May 21, 2026 18:30
Copy link
Copy Markdown
Member

@ericonr ericonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you wrap the text of the second commit? Something like

Expose NDPluginCodec functions with NDPLUGIN_API

This way, the compress/decompress functions can be accessed with
-fvisibility=hidden.

This fixes linking test_NDPluginAttribute with function compressZlib.

This way, the compress/decompress functions can be accessed with
-fvisibility=hidden.

This fixes linking test_NDPluginAttribute with function compressZlib.
@jwlodek jwlodek force-pushed the fix-ndplugin-attribute-test branch from efe4896 to 255665f Compare May 21, 2026 19:43
@jwlodek
Copy link
Copy Markdown
Member Author

jwlodek commented May 21, 2026

Done

@jwlodek jwlodek merged commit b6325f0 into areaDetector:master May 22, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants