Modify tpx3Support to build cpr as part of EPICS build to avoid extra…#3
Conversation
|
There are conflicts in merging this. Please create another PR. OverviewPull Request #3 implements a significant architectural change to the ADTimePix3 EPICS driver by embedding two critical C++ libraries directly into the source tree, eliminating external dependencies and simplifying deployment. 🎯 Primary ObjectiveEmbed ConclusionPull Request #3 represents a well-executed architectural improvement that significantly enhances the ADTimePix3 driver's deployment characteristics. By embedding the nlohmann/json and cpr libraries, the driver becomes more self-contained, easier to deploy, and more reliable in diverse EPICS environments. The implementation maintains code quality, follows EPICS conventions, and provides immediate benefits for users while establishing a foundation for easier maintenance and deployment. The minor version discrepancy in the JSON library (3.12.0 vs expected 3.11.2) is actually beneficial, providing the latest improvements and bug fixes. This change aligns well with the goals of scientific facilities where external dependencies can be challenging to manage, making the ADTimePix3 driver more accessible and reliable for TimePix3 detector integration in EPICS environments. |
|
I've merged with |
|
Indeed there were notes added to this README.me for migration of cpr from tags/1.9.1 to cpr-1.12.1. commit 98b27ef |
2 participants
… steps during setup
With this change, only a
makein the driver directory is required to build, rather than the setup of cpr or json first.