Add ADPimega as a submodule (branch: lumentum-v3)#95
Add ADPimega as a submodule (branch: lumentum-v3)#95Gabriel-Amorim255 wants to merge 1 commit intoareaDetector:masterfrom
Conversation
|
I don't think this PR is ready.
|
|
Hello Mark, First, thank you for the review! I had a feeling that a few things were missing, but I wanted to open this initial PR to gather feedback on how to properly prepare the final version. I actually wanted to ask who I should contact—or what the process is—to have ADPimega added under the areaDetector project. I couldn’t find any clear instructions on how to do that, so any guidance would be greatly appreciated. Regarding the documentation and the synApps folder: I’ve added the relevant submodules using the commit (07b881), which is the one currently in sync with the latest updates from the lumentum-v3 branch. However, the URL specified in the submodule points to master, which may be causing some confusion. Ideally, if we could add this lumentum-v3 branch under the areaDetector organization, that would be best, as we could continue to update it there. If using master is a requirement, we can reach out to CNPEM to request an update. The README.md has also been updated in that branch, and now includes a clearer note on the dependency for the PIMEGA API:
As for the copy of NDFile.template, I still need to investigate why it's present. I’ll look through the commit history to see if any modifications were made to it and run some tests to determine whether it's actually being used. If it turns out to be redundant, I’ll remove it. Thanks again for your time and support! |
Add ADPimega as submodule to interface with Pitec detectors.