ADH-4394 [UI] Add date range picker and calendar#44
Merged
remizov-arena merged 4 commits intodevelopfrom May 24, 2024
Merged
Conversation
rimakan
requested review from
KuzminIA,
MrHalless,
alatunov,
dbardin90,
remizov-arena and
workNpp
as code owners
dbardin90
reviewed
May 23, 2024
| { id: 'now-4h', description: 'last 4 hours' }, | ||
| { id: 'now-8h', description: 'last 8 hours' }, | ||
| { id: 'now-12h', description: 'last 12 hours' }, | ||
| { id: 'now-24h', description: 'last 24 hours' }, |
Collaborator
There was a problem hiding this comment.
I think we can take last @remizov-arena changes from adcc
from this mr https://gitlab.adsw.io/arenadata/development/adbcc/-/merge_requests/2928
Collaborator
There was a problem hiding this comment.
I think no. I change default presets for ADCC, because it was agreed upon with Voronkov. But presets from this MR uses in ADQM, and it's correct for ADQM bussines issues.
We change this presets in every time in future
| const [localDate, setLocalDate] = useState<Date | undefined>(undefined); | ||
| const [localRangeFrom, setLocalRangeFrom] = useState(rangeFrom); | ||
| const [localRangeTo, setLocalRangeTo] = useState(rangeTo); | ||
|
|
Collaborator
There was a problem hiding this comment.
Add pls code for swap values when localRangeFom > localRangeTo
| @@ -0,0 +1,14 @@ | |||
| export const monthsDictionary: Record<number, string> = { | |||
Collaborator
There was a problem hiding this comment.
There is License section in README.md, should read this secation.
Should run maven command for append license info to new files
remizov-arena
approved these changes
May 24, 2024
dbardin90
approved these changes
May 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://tracker.yandex.ru/ADH-4394