Conversation
dgusakov
reviewed
Oct 12, 2021
dgusakov
previously approved these changes
Oct 13, 2021
Contributor
Author
|
@dgusakov I also suggest some refactoring of P.S. doctests are fine |
dgusakov
reviewed
Oct 13, 2021
alexterent
previously approved these changes
Oct 13, 2021
dgusakov
suggested changes
Oct 14, 2021
Contributor
dgusakov
left a comment
dgusakov
left a comment
There was a problem hiding this comment.
@Sealwing There are issues with sorting on collect https://ci.arenadata.io/blue/organizations/jenkins/PR-builder-adcm_pytest_plugin/detail/PR-builder-adcm_pytest_plugin/1856/pipeline/241 Fix them pls
|
Kudos, SonarCloud Quality Gate passed!
|
skhomuti
previously approved these changes
Oct 15, 2021
skhomuti
approved these changes
Oct 15, 2021
alexterent
approved these changes
Oct 15, 2021
dgusakov
approved these changes
Oct 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sorted returns wrong order or versions because of "dotted" and "non-dotted" versions