This repository was archived by the owner on Oct 2, 2025. It is now read-only.
forked from greenplum-db/gpbackup-archive
-
Notifications
You must be signed in to change notification settings - Fork 4
ADBDEV-7890 Support subset restore with on-error-continue mode #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
RekGRpth
reviewed
Sep 3, 2025
RekGRpth
reviewed
Sep 3, 2025
Author
Yes. The task is not to change plugin interface |
RekGRpth
reviewed
Sep 3, 2025
RekGRpth
reviewed
Sep 3, 2025
RekGRpth
reviewed
Sep 3, 2025
This reverts commit bbae9ba.
RekGRpth
reviewed
Sep 3, 2025
RekGRpth
reviewed
Sep 3, 2025
RekGRpth
reviewed
Sep 3, 2025
RekGRpth
reviewed
Sep 3, 2025
RekGRpth
reviewed
Sep 3, 2025
RekGRpth
reviewed
Sep 9, 2025
RekGRpth
reviewed
Sep 11, 2025
RekGRpth
reviewed
Sep 11, 2025
RekGRpth
reviewed
Sep 12, 2025
RekGRpth
reviewed
Sep 12, 2025
RekGRpth
reviewed
Sep 15, 2025
RekGRpth
reviewed
Sep 15, 2025
RekGRpth
reviewed
Sep 15, 2025
This comment was marked as resolved.
This comment was marked as resolved.
dkovalev1
reviewed
Sep 16, 2025
RekGRpth
reviewed
Sep 16, 2025
dkovalev1
approved these changes
Sep 16, 2025
RekGRpth
approved these changes
Sep 16, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support subset restore with on-error-continue mode
Add possibility to use on-error-continue with filtering.
Add the discardData method to the IRestoreReader interface. When an error
happens during
COPY FROMexecution, discardData is called to read the rest ofthe table data from plugin's pipe. So the transition to the next table occurs
and the offset is positioned automatically.
In the case of discard error we don't stop the helper, because other helpers can
restore data on other segments. Another reason - hanging on COPY happens when
one helper stops before restoring a next table. Add the discardErr boolean field
to RestoreReader. This field is used in discardData and copyData to avoid
bufReader reading when an error has happened in discardData before.
When skip file is found, call discardData to move on the next table data.
Data written in writeTestTOC has now started to be used. Fix this data.
Ticket: ADBDEV-7890