ADBDEV-2092: Different number of interfaces per host#268
Closed
ADBDEV-2092: Different number of interfaces per host#268
Conversation
Member
|
bender build |
tsdkv
force-pushed
the
ADBDEV-2092
branch
3 times, most recently
from
303437b to
7284e7b
Compare
tsdkv
changed the title
| if [ `$ECHO ${M_HOST_ARRAY[@]}|$TR ' ' '\n'|$AWK -F"~" '{print $2}'|$SORT -u|$WC -l` -ne $MCOUNT ];then | ||
| COUNT_MHOST_NODES=`$ECHO ${M_HOST_ARRAY[@]}|$TR ' ' '\n'|$AWK -F"~" '{print $2}'|$UNIQ -c|$AWK '{print $1}'|$SORT -u` | ||
| if [ `$ECHO ${COUNT_MHOST_NODES}|$WC -w` -ne 1 ];then | ||
| ERROR_EXIT "[FATAL]:-Uneven distribution of network interfaces by hosts" 2 |
There was a problem hiding this comment.
Probably is is worth to add more information to show what hosts are not unique.
For example:
LOG_MSG "[FATAL]:-Uneven distribution of network interfaces by hosts" 1
LOG_MSG "[INFO]: Number of hosts: `$ECHO ${M_HOST_ARRAY[@]}|$TR ' ' '\n'|$AWK -F"~" '{print $2}'|$WC -w`" 1
$ECHO ${M_HOST_ARRAY[@]}|$TR ' ' '\n'|$AWK -F"~" '{print $1" -> "$2}'
LOG_MSG "[INFO]: Number of unique hosts: `$ECHO ${COUNT_MHOST_NODES}|$WC -w`" 1
ERROR_EXIT "[FATAL]:-Unable to continue" 2
Will produce:
20211213:13:36:04:025358 gpinitsystem:ssmirnov-mdw:gpadmin-[FATAL]:-Uneven distribution of network interfaces by hosts
20211213:13:36:04:025358 gpinitsystem:ssmirnov-mdw:gpadmin-[INFO]: Number of hosts: 3
ssmirnov-sdw1-1 -> ssmirnov-sdw1
ssmirnov-sdw2-1 -> ssmirnov-sdw2
ssmirnov-sdw2-2 -> ssmirnov-sdw2
20211213:13:36:05:025358 gpinitsystem:ssmirnov-mdw:gpadmin-[INFO]: Number of unique hosts: 2
20211213:13:36:05:025358 gpinitsystem:ssmirnov-mdw:gpadmin-[FATAL]:-Unable to continue Script Exiting!
There was a problem hiding this comment.
For me this improvement looks nice and gives precise information to fix error.
RekGRpth
pushed a commit
that referenced
this pull request
Mar 2, 2026
Isolation tests run as separate make rules, all of them outputting to the same directory. Because of this, regression.diffs file gets overwritten, and so its contents for earlier runs are lost. To fix this, use --outputdir option to put them all into separate directories, together with results directory, and also auto-generated sql and results. pg_regress also had an issue that it created these directories in the current folder, not in --outputdir, which is also fixed here for --outputdir to work properly. Changes from original commit: 1. There are less test suites in 6X, unnecessary changes removed. 2. Update path to resgroup tests output in run_resgroup_test.bash. 3. Add missing directory creation. 4. Update hardcoded .so path in resgroup tests Ticket: GG-215 (cherry picked from commit 5a495764fe5886d924d68890f86838b7af5c9cce)
|
Нахожусь в отпуске с 16.03 - 18.03 включительно с ограниченным доступом к почте.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment there is a problem with the different number of interfaces per host. It has not been checked.
Example host file:
The
gpinitsystemdidn't check the different number of interfaces. It only used the first host as a template for counting, assuming that the others had same number.