Addbdeb 3223 v2#429
Closed
HustonMmmavr wants to merge 7 commits into
Closed
Conversation
- no need to add addititonal check at exec scrpt - no need to warn about setting segemnt value at create extension if smth goes wrong leader catches the exception at exec scrpt and run the create stmt with state end (cleanup) - no need to have an if stmt at ApplyExtension ... because this logic is moved to exec scrpt for qe/qd utility. so all needed (previously code duplicate) setting of variables are set from part of exec scrpt - todo check that big if stmt was correctly splitted - todo check that Exec is correctly handled especially in case of create extension from unpackaged - there is no need to have a break condition in a loop of ApplyUpdate for qe - at the beginnin of function assert
to fix problem - when railses segment coordinator raises too
HustonMmmavr
commented
Nov 19, 2022
| * QE may call this function with an empty updateVersions (like at postgres) - noop | ||
| */ | ||
| AssertImply(Gp_role == GP_ROLE_EXECUTE, list_length(updateVersions) == 1); | ||
| AssertImply(Gp_role == GP_ROLE_EXECUTE, list_length(updateVersions) <= 1); |
Author
There was a problem hiding this comment.
no, if segment will call this function without command from QD (from CreateExtension) here will be a problem - updateVersions list at QE is the same as at QD, so for loop works and it leads to errors
Author
|
Duplicate of #430 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are some reminders before you submit the pull request
make installcheck