Skip to content

Fix ccnt overflow in gpperfmon#62

Merged
darthunix merged 1 commit intoccnt_overflowfrom
ADBDEV-728
Apr 14, 2020
Merged

Fix ccnt overflow in gpperfmon#62
darthunix merged 1 commit intoccnt_overflowfrom
ADBDEV-728

Conversation

@darthunix
Copy link

For some reason gpmon_qexeckey_t structure used int16 for ccnt while all other GP code operates int32. This problem can cause ccnt overflow in gpperfmon packets.

For some reason gpmon_qexeckey_t structure used int16 for ccnt
while all other GP code operates int32. This problem can cause ccnt
overflow in gpperfmon packets.
Copy link

@leskin-in leskin-in left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose everything is correct here.

What is the reason for our unit tests to fail?

@darthunix
Copy link
Author

Failed tests are caused by a bug in CI (now it is fixed)

@darthunix darthunix merged commit fdb69ed into ccnt_overflow Apr 14, 2020
@darthunix darthunix deleted the ADBDEV-728 branch June 22, 2020 01:33
RekGRpth pushed a commit that referenced this pull request Dec 3, 2025
In some cases processing of injected panic fault can take a long time.
So queries, sent after sending fault, can either complete
successfully or end with an error.
To prevent this uncertainty the waiting mechanism was introduced in
test - before sending next commands after injecting panic fault, we wait
for it to be fully processed that is to trigger SIGCHLD.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments