-
Notifications
You must be signed in to change notification settings - Fork 3
Description
Describe the feature you'd like.
This issue is related to #49 , but because upwards flowing systems are a lower priority than downwards flowing ones, I've made this a separate issue at the lowest tier of importance.
Molten Salt Reactors (MSRs) can also use pebble-type fuel. In this scenario, the pebbles float in the molten salt, and so the flow is upward, instead of downward Ghastly currently has very basic support for upwards flowing systems implemented - but because I personally focus on HTGRs, it isn't as thoroughly tested as downwards flowing vessels.
This issue is not about figuring out the correct material parameters or appropriate flow speeds for these reactors. This feature is purely, and simply: if the user tells Ghastly the flow is up, does Ghastly create an input file that will run in LAMMPS without errors? If you encounter an error, make an issue in undergrad tasks (which you can also set to the lowest priority).
Another note: the core filling in LAMMPS for such as system is a bit odd, due to a limitation in LAMMPS itself. The command in LAMMPS that pours new pebbles into the core vessel only works if gravity is pointing down. So, when Ghastly fills the core, it starts with gravity pointing down and pours pebbles until there are enough. Then, upwards flowing systems have a special additional set of commands that are used to reverse gravity and let the core settle in the correct direction.
How can this issue be closed?
This issue can be closed when very basic upwards flowing systems have been verified to work in Ghastly, and changes are added as needed. Getting an accurate pressure gradient or accurate material properties is left to the user.