refactor: improve connection management#20
Merged
xfiive merged 2 commits intofeat/bubble-uifrom Feb 24, 2026
Merged
Conversation
Replaces per-call http.Client creation with a package-level shared client. Enables TCP connection pooling across manifest fetch calls.
Replaces grpc.DialContext + WithBlock with grpc.NewClient which is non-blocking and the recommended API going forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves HTTP and gRPC connection management to reduce latency and use current APIs:
http.Clientin the manifest fetcher enables TCP connection pooling instead of creating a new client per callgrpc.DialContext+WithBlocktogrpc.NewClientwhich is non-blocking and the recommended gRPC-Go API