Skip to content

Fix ffi fixed sized integers.#337

Merged
TApplencourt merged 2 commits intodevelfrom
fix-ffi-fixed-ints
Mar 25, 2025
Merged

Fix ffi fixed sized integers.#337
TApplencourt merged 2 commits intodevelfrom
fix-ffi-fixed-ints

Conversation

@Kerilk
Copy link
Collaborator

@Kerilk Kerilk commented Mar 25, 2025

After this patch, we should not have any :uintxx_t inside the generated ruby libraries, but :uintxx

Will need to fix babeltrace2 bindings as well

@Kerilk Kerilk requested a review from TApplencourt March 25, 2025 18:47
@TApplencourt
Copy link
Collaborator

TApplencourt commented Mar 25, 2025

Then the [Check same generated files] is broken, it should have changed something no -- and hence not passing?

@Kerilk
Copy link
Collaborator Author

Kerilk commented Mar 25, 2025

Yeah maybe I fumbled the regexp, in the cab right now...

@TApplencourt
Copy link
Collaborator

Ah nice! Working as expected now

             :uint32�-_t�,\n',     '             :uint32,\n',    
             ```

@TApplencourt
Copy link
Collaborator

So before it was :uint32-_t and now it's uint32? Or I screw up the new / ref order

@Kerilk
Copy link
Collaborator Author

Kerilk commented Mar 25, 2025

:unt32_t becomes :uint32
The - comes from the diff

@TApplencourt
Copy link
Collaborator

Ok perfect, so the diff look good.

@Kerilk
Copy link
Collaborator Author

Kerilk commented Mar 25, 2025

If you could check there are no leftovers then we can merge

@TApplencourt TApplencourt merged commit 6fcfaaf into devel Mar 25, 2025
17 of 18 checks passed
@TApplencourt TApplencourt deleted the fix-ffi-fixed-ints branch March 25, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants