Skip to content

Conversation

@thilinarmtb
Copy link
Member

@thilinarmtb thilinarmtb commented Jan 26, 2026

Todo

  • Update exec_prefix properly in the generated thapi.pc

@thilinarmtb thilinarmtb changed the title Install a pkg-config file during installation Install a pkg-config file during installation Jan 26, 2026
@thilinarmtb thilinarmtb force-pushed the add_a_pkg_config_file branch from 724a7bd to 8282f17 Compare January 26, 2026 20:32
@thilinarmtb thilinarmtb force-pushed the add_a_pkg_config_file branch from 8282f17 to fd71d11 Compare January 26, 2026 20:38
@thilinarmtb
Copy link
Member Author

@TApplencourt : Let me know if I am missing anything.

@TApplencourt
Copy link
Collaborator

TApplencourt commented Jan 26, 2026

Amazing! Should we change the test to use this? Or we are good they don't require that?
(I guess if not, we should add one test who use it :'D export PKG_CONFIG_PATH=/path/to/pkgconfig:$PKG_CONFIG_PATH and then

pkg-config --modversion mylib

But I guess the problem right now is that we don't have a lib at all : )

Libs: -L${libdir} -lThapi

So maybe in the PR just add modversion and then for the start-stop we can also modify the pkgconfig to add -L and -I?

@thilinarmtb
Copy link
Member Author

Amazing! Should we change the test to use this? Or we are good they don't require that? (I guess if not, we should add one test who use it :'D export PKG_CONFIG_PATH=/path/to/pkgconfig:$PKG_CONFIG_PATH and then

pkg-config --modversion mylib

But I guess the problem right now is that we don't have a lib at all : )

Libs: -L${libdir} -lThapi

So maybe in the PR just add modversion and then for the start-stop we can also modify the pkgconfig to add -L and -I?

That was exactly what I was thinking.

@thilinarmtb thilinarmtb force-pushed the add_a_pkg_config_file branch from 9400665 to a4892b3 Compare January 26, 2026 22:02
@thilinarmtb thilinarmtb force-pushed the add_a_pkg_config_file branch from e545b27 to c63bc51 Compare January 26, 2026 23:06
@TApplencourt TApplencourt merged commit 82a17d2 into devel Jan 26, 2026
23 checks passed
@TApplencourt TApplencourt deleted the add_a_pkg_config_file branch January 26, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants