Including a few more nonabi fortran defines#477
Merged
TApplencourt merged 1 commit intodevelfrom Mar 4, 2026
Merged
Conversation
TApplencourt
reviewed
Mar 4, 2026
backends/mpi/headers.patch
Outdated
| +int MPIR_fortran_true = 1; | ||
| +int MPIR_fortran_false = 0; | ||
| +#endif | ||
| + |
Collaborator
There was a problem hiding this comment.
My poor OCD... can you snikely remove the space? Thanks!
TApplencourt
approved these changes
Mar 4, 2026
Collaborator
|
(approving now, so I don't forget, but lets wait for @abagusetty greenlight before we merge this :) ) |
colleeneb
force-pushed
the
fortran_nonabi_add
branch
from
a1a0516 to
26138da
Compare
|
@colleeneb @TApplencourt That worked! Thanks for the fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the next-eval queue on Aurora, there is a newer MPICH which has more non-ABI fortran defines than before, likely due to pmodels/mpich@d6a6ffd.
This updates
mpi/headers.patchto add in the additional defines. Thanks to @abagusetty for noticing the issue.(Adding that this is an extension of #443)