Skip to content
This repository was archived by the owner on Dec 17, 2025. It is now read-only.

Comments

feat: cluster cache should expose synchronization error#32

Merged
alexmt merged 1 commit intomasterfrom
expose-sync-error
May 18, 2020
Merged

feat: cluster cache should expose synchronization error#32
alexmt merged 1 commit intomasterfrom
expose-sync-error

Conversation

@alexmt
Copy link
Contributor

@alexmt alexmt commented May 18, 2020

PR allows accessing most recent cluster cache synchronization error. Also adds comments to the top level cluster cache API.

@alexmt alexmt requested a review from mayzhang2000 May 18, 2020 16:46
@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #32 into master will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #32      +/-   ##
==========================================
- Coverage   51.73%   51.71%   -0.03%     
==========================================
  Files          24       24              
  Lines        2559     2560       +1     
==========================================
  Hits         1324     1324              
- Misses       1110     1111       +1     
  Partials      125      125              
Impacted Files Coverage Δ
pkg/utils/kube/cache/cluster.go 49.20% <0.00%> (-0.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8430dc0...19e8f3b. Read the comment docs.

@alexmt alexmt force-pushed the expose-sync-error branch from 3e781bc to 19e8f3b Compare May 18, 2020 17:03
@alexmt alexmt requested a review from mayzhang2000 May 18, 2020 17:17
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@mayzhang2000 mayzhang2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mayzhang2000 mayzhang2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexmt alexmt merged commit 9163758 into master May 18, 2020
@alexmt alexmt deleted the expose-sync-error branch May 18, 2020 17:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants