Skip to content

Fix pattern matching#347

Merged
Y-Nak merged 6 commits into
argotorg:mainfrom
Y-Nak:fix-pattern-matching
May 6, 2026
Merged

Fix pattern matching#347
Y-Nak merged 6 commits into
argotorg:mainfrom
Y-Nak:fix-pattern-matching

Conversation

@Y-Nak

@Y-Nak Y-Nak commented Apr 6, 2026

Copy link
Copy Markdown
Member
  • Fix a crash when a variable-only match branch contains multiple statements
  • Avoid duplicating scrutinee evaluation in variable match branches
  • Limit ormolu check to tracked source directories

@Y-Nak Y-Nak requested a review from rodrigogribeiro April 6, 2026 13:06
@Y-Nak Y-Nak force-pushed the fix-pattern-matching branch from cd9c08c to a661462 Compare April 6, 2026 13:18
@mbenke

mbenke commented Apr 7, 2026

Copy link
Copy Markdown
Collaborator

Maybe we should consider adding a block statement to the abstract syntax(es). I do not feel good about the Match [] [([], body)] hack.

@rodrigogribeiro rodrigogribeiro left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks!

@Y-Nak Y-Nak merged commit e03dfa0 into argotorg:main May 6, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants