Skolem let fix#374
Merged
Merged
Conversation
Collaborator
|
I have some doubts about the error message: ...but x is in fact declared to have type a (which is misrepresented in the error message) and the problem is in |
mbenke
approved these changes
May 13, 2026
mbenke
left a comment
Collaborator
There was a problem hiding this comment.
Well done. Just minor complaints (feel free to ignore my rant about error message).
Co-authored-by: Marcin Benke <marcin.benke@argot.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue in type checking Yul code and adds a test case suggested by @mbenke.