Remove legacy NumLib and tests for it#420
Merged
Merged
Conversation
axic
commented
May 27, 2026
| @@ -1,162 +0,0 @@ | |||
| import types; | |||
Contributor
Author
There was a problem hiding this comment.
This was failing anyway, it is imported by IndexLib which only had a "runTestExpectingFailure" test case. It also shows those kind of "expect to fail" test are not very useful unless a specific error message is also expected.
axic
commented
May 27, 2026
Contributor
Author
There was a problem hiding this comment.
This file was not in Cases.hs
axic
commented
May 27, 2026
axic
commented
May 27, 2026
Contributor
Author
There was a problem hiding this comment.
The tests of this are also contained in 126nanoerc20.solc nad 127microerc20.solc.
mbenke
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up of #398