Resolve qualified constructor access on same-name-constructor types#429
Merged
Conversation
When a data type T has a same-name constructor (e.g. data Error = Error(word) | Empty | ...), the inner resolver for the bare receiver @error@ in @Error.Empty@ eagerly produced @con (QualName Error Error) []@. The outer ExpVar/ExpName resolver only matched @just (Var d)@ for qualifier-style access, so it fell through to the catch-all and reported "Unqualified constructor: Empty. Use Type.Constructor form." — even though the user had used the qualified form. Treat a same-name no-arg constructor receiver as if it were @var d@ before dispatching on the case table, restoring the qualifier-handling paths for @Error.Empty@ and @Error.Msg(x)@.
axic
commented
Jun 2, 2026
| -- the inner resolver eagerly produces @Con (QualName Error Error) []@ for the | ||
| -- bare name. Treat that shape as if it were @Var Error@ when it appears in | ||
| -- qualifier position so the outer qualifier-handling cases still match. | ||
| unwrapQualifierReceiver :: Maybe (Exp Name) -> Maybe (Exp Name) |
Contributor
Author
There was a problem hiding this comment.
I have no clue about this "fix", but it does work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a data type T has a same-name constructor (e.g.
data Error = Error(word) | Empty | ...), the inner resolver for the bare receiver@Error@in@Error.Empty@eagerly produced@Con (QualName Error Error) []@. The outer ExpVar/ExpName resolver only matched@Just (Var d)@for qualifier-style access, so it fell through to the catch-all and reported "Unqualified constructor: Empty. Use Type.Constructor form." — even though the user had used the qualified form.Treat a same-name no-arg constructor receiver as if it were
@Var d@before dispatching on the case table, restoring the qualifier-handling paths for@Error.Empty@and@Error.Msg(x)@.Fixes #430