Renaming import fix#433
Merged
Merged
Conversation
rodrigogribeiro
commented
Jun 3, 2026
rodrigogribeiro
commented
Collaborator
- This PR fixes a problem in renaming functions names during imports.
- Some tests were commented to await the merge of the opcodes branch.
Add support for import aliases (as syntax) in ImportOnly declarations. Implements typedAliasingWrapper to create forwarding wrappers with renamed signatures. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
rodrigogribeiro
force-pushed
the
rename-import-fix
branch
from
5efb57c to
3b45458
Compare
axic
reviewed
Jun 3, 2026
| [ runDispatchTest "basic.solc", | ||
| runDispatchTest "stringid.solc", | ||
| runDispatchTest "miniERC20.solc", | ||
| [ -- runDispatchTest "basic.solc", |
Contributor
There was a problem hiding this comment.
I think this commenting out is not needed for this PR?
Collaborator
Author
There was a problem hiding this comment.
Yes, you are right. Fixed in the last commit.
mbenke
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.