Fixes on naming resolution#459
Merged
Merged
Conversation
rodrigogribeiro
commented
Jun 11, 2026
rodrigogribeiro
commented
Collaborator
- This PR fixes a bug in naming resolution which I discovered when testing the ABI encoding for algebraic types.
mbenke
approved these changes
Jun 12, 2026
mbenke
left a comment
mbenke
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, couple minor nits
Comment on lines
+551
to
+574
| (Just (Var d), Just TLocalVar) -> do | ||
| ct <- lookupName d | ||
| let qn = QualName d (pretty n) | ||
| case ct of | ||
| Just TClass -> pure (Var qn) | ||
| Just TModule -> do | ||
| qdt <- lookupName qn | ||
| case qdt of | ||
| Just TFunction -> pure (Var qn) | ||
| Just TDataCon -> Con <$> resolveQualifiedConstructorName d n <*> pure [] | ||
| _ -> undefinedName n | ||
| _ -> pure (Var n) | ||
| (Just (Var d), Just TParameter) -> do | ||
| ct <- lookupName d | ||
| let qn = QualName d (pretty n) | ||
| case ct of | ||
| Just TClass -> pure (Var qn) | ||
| Just TModule -> do | ||
| qdt <- lookupName qn | ||
| case qdt of | ||
| Just TFunction -> pure (Var qn) | ||
| Just TDataCon -> Con <$> resolveQualifiedConstructorName d n <*> pure [] | ||
| _ -> undefinedName n | ||
| _ -> pure (Var n) |
Collaborator
There was a problem hiding this comment.
Remove code duplication perhaps?
Comment on lines
+712
to
+735
| (Just (Var d), Just TLocalVar) -> do | ||
| ct <- lookupName d | ||
| let qn = QualName d (pretty n) | ||
| case ct of | ||
| Just TClass -> pure (Call Nothing qn es') | ||
| Just TModule -> do | ||
| qdt <- lookupName qn | ||
| case qdt of | ||
| Just TFunction -> pure (Call Nothing qn es') | ||
| Just TDataCon -> Con <$> resolveQualifiedConstructorName d n <*> pure es' | ||
| _ -> undefinedName n | ||
| _ -> pure (Call Nothing n es') | ||
| (Just (Var d), Just TParameter) -> do | ||
| ct <- lookupName d | ||
| let qn = QualName d (pretty n) | ||
| case ct of | ||
| Just TClass -> pure (Call Nothing qn es') | ||
| Just TModule -> do | ||
| qdt <- lookupName qn | ||
| case qdt of | ||
| Just TFunction -> pure (Call Nothing qn es') | ||
| Just TDataCon -> Con <$> resolveQualifiedConstructorName d n <*> pure es' | ||
| _ -> undefinedName n | ||
| _ -> pure (Call Nothing n es') |
| case qdt of | ||
| Just TFunction -> pure (Var qn) | ||
| Just TDataCon -> Con <$> resolveQualifiedConstructorName d n <*> pure [] | ||
| _ -> undefinedName n |
Collaborator
There was a problem hiding this comment.
might be better to include qualified name in the error message
rodrigogribeiro
force-pushed
the
name-resolution-fix-adt
branch
from
f71e947 to
b899d51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.